Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When revising a fusion variant, allow for optional exon coordinates #1178

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

acoffman
Copy link
Member

Previously, the revise fusion variant form shared the same validation rules as the "create fusion variant" form. This meant requiring 5' or 3' coordinates to be entered (depending on the properties of the Feature).

However, when revising a representative Fusion variant that may not have coordinates specified, this would render a user unable to provide an alias or additional SO terms.

This changes the rules so that:

  • Exons are required if the corresponding transcript is filled in
  • Transcripts are required if the corresponding exon is filled in
  • Ensembl version and Reference build are required if either transcript is filled in
  • Offset and Offset direction continue to work as before

@acoffman acoffman added the bugfix PR Label for bug fixes. Will appear in release notes. label Jan 15, 2025
Copy link
Contributor

@susannasiebert susannasiebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@acoffman acoffman merged commit f7beda9 into main Jan 15, 2025
6 checks passed
@acoffman acoffman deleted the fix-fusion-form-validation branch January 15, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix PR Label for bug fixes. Will appear in release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants