Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variant creation success message. #959

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

acoffman
Copy link
Member

This allows the variant-submit form to pass in a callback that gets called when a new variant is added. This allows the component to determine if the variant is newly added or preexisting.

closes #954
Screenshot 2023-11-29 at 3 04 54 PM
Screenshot 2023-11-29 at 3 04 34 PM

@acoffman acoffman added the bugfix PR Label for bug fixes. Will appear in release notes. label Nov 29, 2023
@acoffman acoffman requested a review from jmcmichael November 29, 2023 21:08
Copy link
Contributor

@susannasiebert susannasiebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@jmcmichael jmcmichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@susannasiebert susannasiebert merged commit 6a76ffc into main Dec 1, 2023
4 checks passed
@susannasiebert susannasiebert deleted the fix-variant-creation-message branch December 1, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix PR Label for bug fixes. Will appear in release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change variant creation message depending on whether a new variant was created
3 participants