Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image to run pvacview on GCP #1020

Merged
merged 14 commits into from
Feb 13, 2024
Merged

Conversation

Layth17
Copy link
Contributor

@Layth17 Layth17 commented Sep 3, 2023

No description provided.

@susannasiebert
Copy link
Contributor

I was able to test this out and discovered a few minor issues with the update script, which I already talked to @Layth17 about. I'll note them here for posterity:

  • If the docker build fails, the script will continue to run and look as if everything finished successfully. However, no new docker image is created and no new tagged cloud run is created
  • If the update is run with an existing tag, the script finishes successfully but the existing tag won't be updated to point to the latest docker image.
    Both of these situations should result in the script exiting with an appropriate error instead.

@susannasiebert susannasiebert changed the base branch from master to staging February 8, 2024 17:17
@susannasiebert susannasiebert changed the base branch from staging to hotfix February 13, 2024 14:38
Copy link
Contributor

@susannasiebert susannasiebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@susannasiebert susannasiebert merged commit e85394e into griffithlab:hotfix Feb 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants