Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transcript in set #1038

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Transcript in set #1038

merged 1 commit into from
Jan 10, 2024

Conversation

evelyn-schmidt
Copy link
Contributor

adding the line that fixes this error.

@susannasiebert
Copy link
Contributor

susannasiebert commented Nov 13, 2023

Thank you for looking into this bug and making a PR. Your PR looks good to me. However, we will want to try to disentangle your PR from my feature PR and Huiming's update. Your change should also be based on the hotfix branch so we can make an standalone hotfix release for it without inadvertently releasing new features.

The easiest way would be to do the following locally (assuming origin points to git@github.com:griffithlab/pVACtools.git` and not a fork):

git checkout hotfix
git pull origin hotfix
git checkout -b transcript_in_set2
git cherry-pick b61e6f5

This will give you a local branch transcript_in_set2 that is based off of the hotfix branch and only has your commit. At this point you can either push this branch to GitHub separately and make a new PR with that branch, or you can overwrite the transcript_in_set branch on GitHub with what is in transcript_in_set2 locally by pushing your local branch as follows: git push origin transcript_in_set2:transcript_in_set --force-with-lease

@susannasiebert susannasiebert changed the base branch from master to hotfix November 13, 2023 16:46
@susannasiebert susannasiebert linked an issue Nov 14, 2023 that may be closed by this pull request
Copy link
Contributor

@susannasiebert susannasiebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@susannasiebert susannasiebert merged commit a50d155 into hotfix Jan 10, 2024
10 checks passed
@susannasiebert susannasiebert deleted the transcript_in_set branch January 24, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error occurs if there are no transcripts in set
2 participants