Skip to content

Update Dockerfile #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MaxMcSween wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Dockerfile #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions minecraft_ftb/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,18 +6,12 @@ WORKDIR /server
RUN wget -q https://minecraft.curseforge.com/projects/project-ozone-2-reloaded/files/2509703/download -O server.zip &&\
unzip server.zip &&\
rm server.zip &&\
Copy link
Owner

@grinnery grinnery Mar 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last line should not contain &&\

Copy link

@asteed asteed Mar 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicking but &&\ => && \

echo "#By changing the setting below to TRUE you are indicating your agreement to our EULA (https://account.mojang.com/documents/minecraft_eula)." > eula.txt &&\
echo \#$(date) >> eula.txt &&\
echo "eula=true" >> eula.txt &&\
chmod +x ServerStart.sh &&\
chmod +x FTBInstall.sh &&\
./FTBInstall.sh


COPY ops.json /server/ops.json

VOLUME [/server/config]
VOLUME [/server/world]

EXPOSE 25565

CMD ./ServerStart.sh
CMD ./minecraft_server.1.7.10.sh
Copy link
Owner

@grinnery grinnery Mar 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy the line from vanilla, replacing 'server' with 'forge'

Copy link

@asteed asteed Mar 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get better init script alignment pls?