Support Astroid v3 #126
Merged
Support Astroid v3 #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gets things mostly working but leaves a small number of test failures, which I'll address in follow-on commits.
This also appears to fix some tests.
This updates a test expectation which is documented as not caring a great deal about the exact number, so hopefully this is a reasonable fix to make.
PeterJCLaw
force-pushed
the
astroid-v3
branch
from
308dae8 to
f0f61c7
Compare
PeterJCLaw
commented
Oct 24, 2023
Comment on lines
+29
to
+43
| astroid-version: | ||
| - '' | ||
| include: | ||
| # Test recent Python on Astroid v2 too (the above natural tests will | ||
| # pick up Astroid v3 for these Python versions) | ||
| - python-version: '3.8' | ||
| astroid-version: '<3' | ||
| - python-version: '3.9' | ||
| astroid-version: '<3' | ||
| - python-version: '3.10' | ||
| astroid-version: '<3' | ||
| - python-version: '3.11' | ||
| astroid-version: '<3' | ||
| - python-version: '3.12' | ||
| astroid-version: '<3' |
There was a problem hiding this comment.
This doesn't feel the clearest spelling of this, however given the non-overlapping version requirements between Python 2 & 3 it is probably the simplest.
alexmojaki
reviewed
Oct 25, 2023
Co-authored-by: Alex Hall <alex.mojaki@gmail.com>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #125, adding support & testing for
astroidv3. See commits for details.Fixes #100.