Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.7.4] - fix: solving issue with open go routines #22

Merged
merged 2 commits into from
Nov 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ jobs:
with:
go-version: "1.23"
- name: build package
env:
CGO_ENABLED: 0
GOOS: linux
# env:
# CGO_ENABLED: 0
# GOOS: linux
run: |
go mod tidy
go build -a -installsuffix cgo -o entrypoint pkg/**/*.go
go build -race -a -installsuffix cgo -o entrypoint pkg/**/*.go
2 changes: 1 addition & 1 deletion .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
- name: install deps
run: go mod tidy
- name: run test
run: go test -v -coverprofile=profile.cov ./...
run: go test -race -v -coverprofile=profile.cov ./...

- name: Send coverage to coverall.io
uses: shogo82148/actions-goveralls@v1
Expand Down
2 changes: 1 addition & 1 deletion pkg/healthcheck/health_checker.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ func HealthCheckerDetailed(config ApplicationConfig) ApplicationHealthDetailed {
go func() {
wg.Wait()
close(checklist)
result.Duration = time.Since(start).Seconds()
}()
result.Duration = time.Since(start).Seconds()
for chk := range checklist {
result.Integrations = append(result.Integrations, chk)
}
Expand Down
Loading