Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styled components 6 test #3572

Closed
wants to merge 4 commits into from
Closed

Styled components 6 test #3572

wants to merge 4 commits into from

Conversation

jcfilben
Copy link
Collaborator

@jcfilben jcfilben commented Oct 24, 2023

What does this PR do?

Deploy preview

Testing the grommet styled components 6 beta branch on the design system site

Where should the reviewer start?

What testing has been done on this PR?

In addition to the feature you are implementing, have you checked the following:

General UX Checks

  • Small, medium, and large screen sizes
  • Cross-browsers (FireFox, Chrome, and Safari)
  • Light & dark modes
  • All hyperlinks route properly

Accessibility Checks

  • Keyboard interactions
  • Screen reader experience
  • Run WAVE accessibility plugin (Chrome)

Code Quality Checks

  • Console is free of warnings and errors
  • Passes E2E commit checks
  • Visual snapshots are reasonable

How should this be manually tested?

Any background context you want to provide?

What are the relevant issues?

Screenshots (if appropriate)

Should this PR be mentioned in Design System updates?

Is this change backwards compatible or is it a breaking change?

@jcfilben jcfilben marked this pull request as draft October 24, 2023 22:54
package.json Outdated Show resolved Hide resolved
@taysea
Copy link
Collaborator

taysea commented Nov 22, 2023

Closing, this PR is no longer necessary now that the grommet alpha release went out.

@taysea taysea closed this Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants