List - fix accessibility issues with List examples #4414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for unrivaled-bublanina-3a9bae ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
britt6612
reviewed
Nov 18, 2024
| @@ -48,6 +48,7 @@ const data = [ | |||
| export const ListImageIdentifierExample = () => ( | |||
| <Box width={{ max: 'xxlarge' }} margin="auto" fill> | |||
| <List | |||
| aria-label="Locations of people and image of location" | |||
There was a problem hiding this comment.
image showing the locations where people are currently situated
There was a problem hiding this comment.
Yeah that makes more sense, I'll make that change
There was a problem hiding this comment.
Updated aria-label
|
just one comment and fix yarn file then looks good |
britt6612
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deploy Preview
What does this PR do?
Fixes accessibility issues that were flagged by the storybook automated accessibility tool in the List examples
Where should the reviewer start?
What testing has been done on this PR?
Storybook testing
In addition to the feature you are implementing, have you checked the following:
General UX Checks
Accessibility Checks
Code Quality Checks
How should this be manually tested?
Any background context you want to provide?
What are the relevant issues?
Closes #4366
Screenshots (if appropriate)
Should this PR be mentioned in Design System updates?
no
Is this change backwards compatible or is it a breaking change?
backwards compatible