Demo App - Added Empty state #4678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Deploy Preview for unrivaled-bublanina-3a9bae ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
taysea
reviewed
Jan 15, 2025
| @@ -1 +1,2 @@ | |||
| export * from './Collection'; | |||
| export * from './EmptyState'; | |||
There was a problem hiding this comment.
Suggested change
| export * from './EmptyState'; | |
| export * from './EmptyState'; | |
taysea
reviewed
Jan 15, 2025
| @@ -0,0 +1 @@ | |||
| export * from './EmptyState'; | |||
There was a problem hiding this comment.
Suggested change
| export * from './EmptyState'; | |
| export * from './EmptyState'; | |
taysea
reviewed
Jan 15, 2025
| placeholder={data.length === 0 && | ||
| <Box pad="xlarge"> | ||
| <EmptyState | ||
| title="No Bare Metal instances." |
There was a problem hiding this comment.
Suggested change
| title="No Bare Metal instances." | |
| title="No Bare Metal instances" |
In our examples we don't use "."
taysea
reviewed
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deploy Preview
What does this PR do?
Where should the reviewer start?
What testing has been done on this PR?
In addition to the feature you are implementing, have you checked the following:
General UX Checks
Accessibility Checks
Code Quality Checks
How should this be manually tested?
Any background context you want to provide?
What are the relevant issues?
Screenshots (if appropriate)
Should this PR be mentioned in Design System updates?
Is this change backwards compatible or is it a breaking change?