Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose get_parameter for more types #305

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

sagudev
Copy link
Contributor

@sagudev sagudev commented Sep 27, 2024

#190 without tidy changes. We can add more later in followup PRs.

Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
Co-authored-by: grovesNL <josh@joshgroves.com>
@sagudev sagudev changed the title Expose more get_parameter types Expose get_parameter for more types Sep 28, 2024
Copy link
Owner

@grovesNL grovesNL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you! Coincidentally somebody had just asked about this a couple of weeks ago

@grovesNL grovesNL merged commit 57995d9 into grovesNL:main Oct 1, 2024
6 checks passed
@sagudev
Copy link
Contributor Author

sagudev commented Oct 1, 2024

Would it be possible to get new release with this?

@sagudev
Copy link
Contributor Author

sagudev commented Oct 1, 2024

Actually, I will also need get_parameter_bool_array, that I will make PR for today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants