Pixel(Un)PackData with None #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
This was referenced Nov 6, 2024
|
@grovesNL This is ready for review! |
|
Thanks! Could you also create new release (due to various breaking changes it would need to be 0.16)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As announced in #322 (comment).
Optionis put intoPixelUnpackData::Slicevariant because it matches webgl better.Alternatives:
PixelUnpackData::Nonevariantdo nothing as we can already express this asactually this is not true, there is no way to pass null/0 in WebGL 1 context as BufferOffset variants are not supported by spec (glow panics) but null value is supported by spec (for example seePixelUnpackData::BufferOffset(0)tex_image_2d).