Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link to examples #731

Closed

Conversation

tatsuyafujisaki
Copy link

@tatsuyafujisaki tatsuyafujisaki commented Aug 19, 2024

On the following page, clicking "Examples" shows 404 Not Found. This pull request fixes it.
https://pub.dev/documentation/grpc/latest/

Copy link

linux-foundation-easycla bot commented Aug 19, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: tatsuyafujisaki / name: Tatsuya Fujisaki (db9d281)
  • ✅ login: mosuem / name: Moritz (f374023, ba21572)

Copy link
Contributor

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link

github-actions bot commented Aug 20, 2024

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
grpc None 4.0.2 4.0.2 4.0.2 ✔️
Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
grpc $1.Duration
ServerHandler
Any

This check can be disabled by tagging the PR with skip-leaking-check.

Package publish validation ✔️
Package Version Status
package:grpc 4.0.2 ready to publish

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@mosuem
Copy link
Contributor

mosuem commented Sep 2, 2024

Link seems to work fine - closing for now.

@mosuem mosuem closed this Sep 2, 2024
@tatsuyafujisaki
Copy link
Author

@mosuem
No, it doesn't.

Please follow these steps to reproduce the problem ...

  1. Open https://pub.dev/documentation/grpc/latest/ in Chrome.
  2. Click "Examples" and the 404 Not Found page will appear.

... or watch the screencast below.

screencast.mp4

@grpc grpc deleted a comment from github-actions bot Sep 6, 2024
@mosuem mosuem reopened this Sep 6, 2024
@mosuem
Copy link
Contributor

mosuem commented Sep 6, 2024

You are right! Thanks for noticing.

@mosuem
Copy link
Contributor

mosuem commented Sep 6, 2024

Landed this as part of #732 - thanks @tatsuyafujisaki !

@mosuem mosuem closed this Sep 6, 2024
@tatsuyafujisaki tatsuyafujisaki deleted the feature/fix-broken-link branch September 8, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants