Skip to content

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Sep 18, 2025

When vet fails because of offending whitespace, the output currently only lists the offending file. This change adds the line number to the output to make it easier on the developer to fix the issue.

RELEASE NOTES: n/a

@easwars easwars requested a review from dfawley September 18, 2025 19:27
@easwars easwars added the Area: Tooling Includes anything related to Go builds, modules etc and includes Releases & Github Workflows. label Sep 18, 2025
@easwars easwars added this to the 1.77 Release milestone Sep 18, 2025
Copy link

codecov bot commented Sep 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.88%. Comparing base (e8ad657) to head (0e35322).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8593      +/-   ##
==========================================
- Coverage   81.91%   81.88%   -0.03%     
==========================================
  Files         415      415              
  Lines       40694    40694              
==========================================
- Hits        33336    33324      -12     
- Misses       5968     5982      +14     
+ Partials     1390     1388       -2     

see 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dfawley dfawley assigned easwars and unassigned dfawley Sep 18, 2025
@easwars easwars added the Type: Meta Github repo, process, etc label Sep 18, 2025
@easwars easwars merged commit 68caa7c into grpc:master Sep 18, 2025
15 of 20 checks passed
@easwars easwars deleted the improve_vet branch September 18, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Tooling Includes anything related to Go builds, modules etc and includes Releases & Github Workflows. Type: Meta Github repo, process, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants