grpc-js-xds: Reference clusters for ConfigSelector lifetime #2883
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, this modifies the
ConfigSelector
API to make it an object instead of a function. The object has aninvoke
method, which is called the same way the function was previously called, and an additionalunref
function, which signals the end of the lifetime of theConfigSelector
. This allows resolvers to track and act on the lifetime of theConfigSelector
.Second, this modifies the xDS resolver so that it keeps a cluster ref for each cluster that a
ConfigSelector
can select, for the lifetime of theConfigSelector
, plus an additional ref for each call for which a cluster has been selected, until that call is committed. This ensures that once aConfigSelector
is created, every cluster it can select will be subscribed to continuously until no more calls need it.