Skip to content

Commit

Permalink
v2 - Upgrade of dependencies and code cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
grubersjoe committed Mar 6, 2019
1 parent 7077a39 commit 4d1f5cc
Show file tree
Hide file tree
Showing 7 changed files with 103 additions and 90 deletions.
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
vendor/
.idea/

.php_cs.cache
.cache/
*.cache

2 changes: 1 addition & 1 deletion LICENSE
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
The MIT License (MIT)

Copyright (c) 2016 Jonathan Gruber
Copyright (c) 2019 Jonathan Gruber

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
Expand Down
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Breaking change as of v1: the parameter `resolution` was renamed to `quality`. S

| Parameter |Description |Default |Valid values|
|-------------|-------------------|---------------------|------------|
| `cacheDir` | Directory for image caching | `null` | An existing directory |
| `cacheDir` | Directory for image caching | `null` | An existing directory, otherwise the directory will be created if possible |
| `date` | Date of photo | `BingPhoto::DATE_TODAY` |`BingPhoto::DATE_YESTERDAY`, `BingPhoto::DATE_TODAY`, `BingPhoto::DATE_TOMORROW`, `any integer >= -1` |
| `locale` |Locale code | `Locale::getDefault()` | Whatever language Bing supports |
| `n` | Number of photos to fetch, going from date backwards | 1 | 1 - 8 |
Expand Down Expand Up @@ -84,7 +84,6 @@ foreach ($bing->getImages() as $image) {

```php
// Using the local cache
// (remember to create the directory first!)
$bing = new grubersjoe\BingPhoto([
'cacheDir' => '/tmp/bing-photo',
'n' => 5,
Expand Down
6 changes: 4 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,12 @@
}
},
"require": {
"php": "^5.6.0 || ^7.0"
"php": "^7.1",
"ext-intl": "*",
"ext-json": "*"
},
"require-dev": {
"phpunit/phpunit": "^7",
"phpunit/phpunit": "^8",
"friendsofphp/php-cs-fixer": "^2"
},
"scripts": {
Expand Down
69 changes: 35 additions & 34 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 4d1f5cc

Please sign in to comment.