Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label option #135

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

sercantor
Copy link

@sercantor sercantor commented Aug 6, 2023

Description

Addresses #134.
GH api doesn't seem to have the option to provide labels with the PR request endpoint, that seems to be in their graphql api.

Added label flag, and a request to add the label after the PR is opened successfully (similar to requesting reviewers)

I have no idea how to write go, but I've added this since I looked at the code, and it looked similar to how you add reviewers to the pr, I've provided a description to why I'd like to use this in the issue I've opened, but if it doesn't suit the CLI's usecase I'll close this PR.

Oh, also I didn't really test it with code, I just made the changes, built it, ran it in my cli for some of my own repos, seems to work OK.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added the option to pass labels to the PRs

@sercantor sercantor requested a review from brikis98 as a code owner August 6, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant