Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for BIN / XBIN encoding #17

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

michael-lazar
Copy link

This PR resolves a handful of issues, shoutout for @TheGreenHerring for the excellent bug tickets 💯

  • Fixes the bug that added two copies of SAUCE in the file when saving XBIN files.
  • Fixes "Save without Sauce Info" to actually save the file without SAUCE info.
  • Fixes opening BIN files without SAUCE info. This was broken because the default column size was set to be 160 for some unclear reason. Dropping it down to 80 allows successfully opening BIN files that are 80x25 without SAUCE info.
  • Fixes the bug preventing saving XBIN files with an uneven number of columns.
  • Now shows a warning when attempting to save BIN files with an uneven number of columns, instead of silently failing.

Resolves

#12
#13
#14
#15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant