Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IDP-1972] Fix missing bin error #24

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

tjosepo
Copy link
Member

@tjosepo tjosepo commented Jul 29, 2024

Description of changes

There was an issue in the repository that made this sequence fail, when cloning the repo for the first time:

  • pnpm install -> pnpm build -> cd debug && pnpm dev

Because the dist/bin.js file was only generated after the pnpm build step, it wasn't installed in the debug project during the initial pnpm install step. This forced developers working on this project to run pnpm install twice, once before the build, and again after the build.

This change adds a /bin/create-schemas.js file which always exists and removes the need to run pnpm install twice.


Boyscout

  • Renamed the /src/bin.ts file to /src/cli.ts, since it is the entrypoint of the CLI.

  • Also add the "files" field to the package.json. I noticed our /test and /src folders got included in the published package. This isn't bad per-se, but we are installing more files than we need to on our user's filesystem, which is rude.

Breaking changes

N/A

Additional checks

N/A

  • Updated the documentation of the project to reflect the changes
  • Added new tests that cover the code changes

@tjosepo tjosepo requested a review from a team as a code owner July 29, 2024 17:48
@tjosepo tjosepo merged commit 3c6be50 into main Jul 29, 2024
2 checks passed
@github-actions github-actions bot mentioned this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants