Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDP-2284 Be more specific about action version pin #34

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

starcraft66
Copy link
Member

@starcraft66 starcraft66 commented Sep 27, 2024

To pin the action tags to digest shas, I think we should use this renovate setting: renovatebot/renovate#11987 in our renovate config, wdyt @asimmon?

To pin the action tags to digest shas, I think we should use this renovate setting: renovatebot/renovate#11987
@asimmon
Copy link
Member

asimmon commented Oct 2, 2024

To pin the action tags to digest shas, I think we should use this renovate setting: renovatebot/renovate#11987 in our renovate config, wdyt @asimmon?

We've previously pinned our GitHub actions in a repo recently but we made the mistake of enabling it for all actions. It created way too many PRs even for trusted actions (built-in GitHub actions like checkout). Very annoying.

If we want to pin the digest for this particular action, we can create a package rule targeting the github-actions Renovate manager and this package anothrNick/github-tag-action, and enable the pinDigests property.

This is what we previously had in the charts repo:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants