Correct cpp-options for both linux/darwin #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This builds on gtk2hs@df6c617. Patching svgcairo on nixpkgs with this commit fixed the linux build but removing one of the flags broke it for darwin. This adds a conditional for darwin and adds the `-D__attribute__(A)=` flag back.
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on df6c617.
Patching
svgcairoon nixpkgs with this commit fixed the linux build but removing one of the flags broke it for darwin. I don't think it's a nixpkgs issue and after some investigation I found similar issues on Github. It seems like we need to retain the-D__attribute__(A)=flag, so this adds it back with aif os(darwin)conditonal.