Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy events multiple template and js file #336

Merged
merged 1 commit into from
Dec 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions legacy/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
- Create a `src/template-name` for the template you're migrating
- Generate `index.html`, `index.scss` and `index.js` following current standards and the specification doc
- Ensure that you are running at least `node` version 6. (You might want to run `nvm use 6`.)
- At the root of the repository run `npm install` and `npm run build`.
- At the root of the repository run `npm install` and `npm run build`.
This will generate HTML and CSS artefacts under `/build/<template-name>`, which can be copied into native styles in GAM.
- You should now be able to test your templates.

Expand Down Expand Up @@ -43,10 +43,6 @@ This will require you to use:
- the [`portify`](https://github.com/guardian/commercial-templates/blob/master/src/_shared/js/dev.js) method in `src/_shared/js/dev.js` to programmatically switch between 7000 and 9000 when making outbound requests.
- the [`JsonComponent`](https://github.com/guardian/frontend/blob/master/common/app/common/JsonComponent.scala) method to serve the JSON response from the frontend controller. This method wraps the JSON response in a [CORS](https://github.com/guardian/frontend/blob/master/common/app/model/Cors.scala) header which allows cross-origin requests.

### Automated ads

A number of ads (`events-multiple` and `masterclass-multiple`) use a reader revenue endpoint. In their associated `test.json` files you will see that the URL's refer to `mem.thegulocal.com` as the domain. The `_src/js/events-multiple.js` needs to be updated to reflect this domain also. This requires the [`membership-frontend`](https://github.com/guardian/membership-frontend) to be running and using the `nginx` server. Make sure to set this up before testing these ads.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spoke to Emma regarding this and she said we can remove this section as events-multiple is migrated to Svelte and masterclass-multiple have been shut down.

## Testing on Frontend (Prod)

There will shortly be an easier way to preview, but for now:
Expand All @@ -63,7 +59,7 @@ There will shortly be an easier way to preview, but for now:

## Code conventions and pre-commit hooks

This project uses [stylelint](https://github.com/stylelint/).
This project uses [stylelint](https://github.com/stylelint/).

To make stylelint list **ALL** errors and warnings, use:

Expand Down
172 changes: 0 additions & 172 deletions legacy/src/_shared/js/events-multiple.js

This file was deleted.

26 changes: 0 additions & 26 deletions legacy/src/events-multiple/test.json

This file was deleted.

51 changes: 0 additions & 51 deletions legacy/src/events-multiple/web/index.html

This file was deleted.

3 changes: 0 additions & 3 deletions legacy/src/events-multiple/web/index.js

This file was deleted.

6 changes: 0 additions & 6 deletions legacy/src/events-multiple/web/index.scss

This file was deleted.

Loading