Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove chips with everything, brexit means and small changes from podcast subnav menu #67

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

tkgnm
Copy link
Contributor

@tkgnm tkgnm commented Sep 26, 2023

What does this change?

This PR removes chips with everything, small changes and brexit means from the podcast subnav menu on the UK edition following a request from Central Production.

Testing

Updated the json in the CODE folder in s3, reployed mobile-fronts, checked on the debug app. If you'd like to do this yourself I've added some testing instructions to the readme of this repo.

Images

Before After

remove chips with everything, small changes and brexit means
@tkgnm tkgnm marked this pull request as ready for review September 26, 2023 18:08
@DavidLawes
Copy link
Contributor

Did we also need to re-order the list (e.g. should comfort eating be third in the list)?

add comfort eating and pop culture, remove neuroscientist explains
@tkgnm
Copy link
Contributor Author

tkgnm commented Sep 27, 2023

Did we also need to re-order the list (e.g. should comfort eating be third in the list)?

Ah thank you - I missed the re-ordering! Made some tweaks and updated the screenshot.

Copy link
Contributor

@DavidLawes DavidLawes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tkgnm tkgnm merged commit e5db733 into main Sep 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants