Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-AWS dependency updates #44

Merged
merged 7 commits into from
Jul 19, 2023
Merged

Non-AWS dependency updates #44

merged 7 commits into from
Jul 19, 2023

Conversation

gu-scala-steward-public-repos[bot]
Copy link
Contributor

About this PR

Updates:

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

πŸ” Files still referring to the old version numbers

The following files still refer to the old version numbers.
You might want to review and update them manually.

cdk/yarn.lock
βš™ Adjust future updates

Add these to your .scala-steward.conf file to ignore future updates of these dependencies:

updates.ignore = [
  { groupId = "com.eed3si9n", artifactId = "sbt-assembly" },
  { groupId = "com.fasterxml.jackson.core", artifactId = "jackson-databind" },
  { groupId = "com.squareup.okhttp3", artifactId = "okhttp" },
  { groupId = "org.scala-lang", artifactId = "scala3-library" },
  { groupId = "org.scala-sbt", artifactId = "sbt" },
  { groupId = "org.slf4j", artifactId = "slf4j-simple" }
]

Or, add these to slow down future updates of these dependencies:

dependencyOverrides = [
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "com.eed3si9n", artifactId = "sbt-assembly" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "com.fasterxml.jackson.core", artifactId = "jackson-databind" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "com.squareup.okhttp3", artifactId = "okhttp" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "org.scala-lang", artifactId = "scala3-library" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "org.scala-sbt", artifactId = "sbt" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "org.slf4j", artifactId = "slf4j-simple" }
  }
]
labels: sbt-plugin-update, library-update, early-semver-major, semver-spec-minor, early-semver-minor, semver-spec-major, version-scheme:semver-spec, version-scheme:early-semver, old-version-remains, commit-count:n:6

This resolves the following `assembly` error:

```
[error] 1 error was encountered during merge
[error] java.lang.RuntimeException: deduplicate: different file contents found in the following:
[error] /home/runner/.cache/coursier/v1/https/repo1.maven.org/maven2/com/squareup/okio/okio-jvm/3.2.0/okio-jvm-3.2.0.jar:META-INF/okio.kotlin_module
[error] /home/runner/.cache/coursier/v1/https/repo1.maven.org/maven2/com/squareup/okio/okio/3.2.0/okio-3.2.0.jar:META-INF/okio.kotlin_module
[error]   at sbtassembly.Assembly$.applyStrategies(Assembly.scala:161)
[error]   at sbtassembly.Assembly$.x$1$lzycompute$1(Assembly.scala:43)
[error]   at sbtassembly.Assembly$.x$1$1(Assembly.scala:41)
[error]   at sbtassembly.Assembly$.stratMapping$lzycompute$1(Assembly.scala:41)
[error]   at sbtassembly.Assembly$.stratMapping$1(Assembly.scala:41)
[error]   at sbtassembly.Assembly$.inputs$lzycompute$1(Assembly.scala:86)
[error]   at sbtassembly.Assembly$.inputs$1(Assembly.scala:76)
[error]   at sbtassembly.Assembly$.apply(Assembly.scala:103)
[error]   at sbtassembly.Assembly$.$anonfun$assemblyTask$1(Assembly.scala:278)
[error]   at scala.Function1.$anonfun$compose$1(Function1.scala:49)
[error]   at sbt.internal.util.$tilde$greater.$anonfun$$u2219$1(TypeFunctions.scala:63)
[error]   at sbt.std.Transform$$anon$4.work(Transform.scala:69)
[error]   at sbt.Execute.$anonfun$submit$2(Execute.scala:283)
[error]   at sbt.internal.util.ErrorHandling$.wideConvert(ErrorHandling.scala:24)
[error]   at sbt.Execute.work(Execute.scala:292)
[error]   at sbt.Execute.$anonfun$submit$1(Execute.scala:283)
[error]   at sbt.ConcurrentRestrictions$$anon$4.$anonfun$submitValid$1(ConcurrentRestrictions.scala:265)
[error]   at sbt.CompletionService$$anon$2.call(CompletionService.scala:65)
[error]   at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
[error]   at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
[error]   at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
[error]   at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
[error]   at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
[error]   at java.base/java.lang.Thread.run(Thread.java:829)
[error] (assembly) deduplicate: different file contents found in the following:
[error] /home/runner/.cache/coursier/v1/https/repo1.maven.org/maven2/com/squareup/okio/okio-jvm/3.2.0/okio-jvm-3.2.0.jar:META-INF/okio.kotlin_module
[error] /home/runner/.cache/coursier/v1/https/repo1.maven.org/maven2/com/squareup/okio/okio/3.2.0/okio-3.2.0.jar:META-INF/okio.kotlin_module
[error] Total time: 2 s, completed Jul 5, 2023, 5:59:37 PM
```
@akash1810
Copy link
Member

I've followed the instructions in the README to run this locally. I get a connection error, but it looks like that's an artifact of running locally as the same happens on main. The end of the logs suggest CloudWatch metrics are being produced:

[info] running com.gu.elasticsearchmonitor.TestIt
[sbt-bg-threads-1] INFO com.gu.elasticsearchmonitor.MasterDetector - Identified these instances as potential candidates: List()
[sbt-bg-threads-1] INFO com.gu.elasticsearchmonitor.MasterDetector - Found the following master information: MasterInformation(0,0,None)
[sbt-bg-threads-1] INFO com.gu.elasticsearchmonitor.Lambda$ - would have resolved with master node None, but forcing back to localhost as the lambda is running locally
[sbt-bg-threads-1] ERROR com.gu.elasticsearchmonitor.ClusterHealth$ - Unable to fetch cluster health
java.net.ConnectException: Failed to connect to localhost/0:0:0:0:0:0:0:1:8000
	at okhttp3.internal.connection.RealConnection.connectSocket(RealConnection.kt:297)
	at okhttp3.internal.connection.RealConnection.connect(RealConnection.kt:207)
	at okhttp3.internal.connection.ExchangeFinder.findConnection(ExchangeFinder.kt:226)
	at okhttp3.internal.connection.ExchangeFinder.findHealthyConnection(ExchangeFinder.kt:106)
	at okhttp3.internal.connection.ExchangeFinder.find(ExchangeFinder.kt:74)
	at okhttp3.internal.connection.RealCall.initExchange$okhttp(RealCall.kt:255)
	at okhttp3.internal.connection.ConnectInterceptor.intercept(ConnectInterceptor.kt:32)
	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
	at okhttp3.internal.cache.CacheInterceptor.intercept(CacheInterceptor.kt:95)
	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
	at okhttp3.internal.http.BridgeInterceptor.intercept(BridgeInterceptor.kt:83)
	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
	at okhttp3.internal.http.RetryAndFollowUpInterceptor.intercept(RetryAndFollowUpInterceptor.kt:76)
	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
	at okhttp3.internal.connection.RealCall.getResponseWithInterceptorChain$okhttp(RealCall.kt:201)
	at okhttp3.internal.connection.RealCall.execute(RealCall.kt:154)
	at com.gu.elasticsearchmonitor.ClusterHealth$.$anonfun$1(ClusterHealth.scala:33)
	at scala.util.Try$.apply(Try.scala:210)
	at com.gu.elasticsearchmonitor.ClusterHealth$.fetchAndParse(ClusterHealth.scala:33)
	at com.gu.elasticsearchmonitor.Lambda$.$anonfun$1(Lambda.scala:82)
	at scala.util.Either.flatMap(Either.scala:352)
	at com.gu.elasticsearchmonitor.Lambda$.fetchAndSendMetrics$1$$anonfun$1(Lambda.scala:86)
	at scala.runtime.function.JProcedure1.apply(JProcedure1.java:15)
	at scala.runtime.function.JProcedure1.apply(JProcedure1.java:10)
	at scala.util.Either.map(Either.scala:382)
	at com.gu.elasticsearchmonitor.Lambda$.fetchAndSendMetrics$1(Lambda.scala:91)
	at com.gu.elasticsearchmonitor.Lambda$.process$$anonfun$1(Lambda.scala:93)
	at scala.util.Try$.apply(Try.scala:210)
	at com.gu.elasticsearchmonitor.Lambda$.process(Lambda.scala:93)
	at com.gu.elasticsearchmonitor.TestIt$.main(Lambda.scala:102)
	at com.gu.elasticsearchmonitor.TestIt.main(Lambda.scala)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at sbt.Run.invokeMain(Run.scala:144)
	at sbt.Run.execute$1(Run.scala:94)
	at sbt.Run.$anonfun$runWithLoader$5(Run.scala:121)
	at sbt.Run$.executeSuccess(Run.scala:187)
	at sbt.Run.runWithLoader(Run.scala:121)
	at sbt.Defaults$.$anonfun$bgRunTask$6(Defaults.scala:1986)
	at sbt.Defaults$.$anonfun$termWrapper$2(Defaults.scala:1925)
	at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:23)
	at scala.util.Try$.apply(Try.scala:213)
	at sbt.internal.BackgroundThreadPool$BackgroundRunnable.run(DefaultBackgroundJobService.scala:367)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:829)
	Suppressed: java.net.ConnectException: Failed to connect to localhost/127.0.0.1:8000
		... 48 more
	Caused by: java.net.ConnectException: Connection refused (Connection refused)
		at java.base/java.net.PlainSocketImpl.socketConnect(Native Method)
		at java.base/java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:412)
		at java.base/java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:255)
		at java.base/java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:237)
		at java.base/java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
		at java.base/java.net.Socket.connect(Socket.java:609)
		at okhttp3.internal.platform.Platform.connectSocket(Platform.kt:128)
		at okhttp3.internal.connection.RealConnection.connectSocket(RealConnection.kt:295)
		... 47 more
Caused by: java.net.ConnectException: Connection refused (Connection refused)
	at java.base/java.net.PlainSocketImpl.socketConnect(Native Method)
	at java.base/java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:412)
	at java.base/java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:255)
	at java.base/java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:237)
	at java.base/java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
	at java.base/java.net.Socket.connect(Socket.java:609)
	at okhttp3.internal.platform.Platform.connectSocket(Platform.kt:128)
	at okhttp3.internal.connection.RealConnection.connectSocket(RealConnection.kt:295)
	... 47 more
[sbt-bg-threads-1] ERROR com.gu.elasticsearchmonitor.Lambda$ - Couldn't fetch cluster health: Unable to fetch cluster health: Failed to connect to localhost/0:0:0:0:0:0:0:1:8000
[sbt-bg-threads-1] INFO com.gu.elasticsearchmonitor.CloudwatchMetrics - About to send 2 metrics
[sbt-bg-threads-1] INFO com.gu.elasticsearchmonitor.CloudwatchMetrics - Sending a batch of 2 metrics to cloudwatch
[sbt-bg-threads-1] INFO com.gu.elasticsearchmonitor.Lambda$ - Successfully finished to send metrics to cloudwatch
()
[success] Total time: 3 s, completed 19 Jul 2023, 09:23:22

@jacobwinch does this look right?

@akash1810
Copy link
Member

I get a connection error, but it looks like that's an artifact of running locally as the same happens on main.

Reading the code,

is the cause. Following the test-data instructions resolves this:

[info] welcome to sbt 1.9.1 (Amazon.com Inc. Java 11.0.15)
[info] loading global plugins from /Users/akash_askoolum/.sbt/1.0/plugins
[info] loading settings for project elastic-search-monitor-build from plugins.sbt ...
[info] loading project definition from /Users/akash_askoolum/code/elastic-search-monitor/project
[info] loading settings for project elastic-search-monitor from build.sbt ...
[info] set current project to elastic-search-monitor (in build file:/Users/akash_askoolum/code/elastic-search-monitor/)
[info] compiling 6 Scala sources to /Users/akash_askoolum/code/elastic-search-monitor/target/scala-3.3.0/classes ...
[info] running com.gu.elasticsearchmonitor.TestIt
[sbt-bg-threads-1] INFO com.gu.elasticsearchmonitor.MasterDetector - Identified these instances as potential candidates: List()
[sbt-bg-threads-1] INFO com.gu.elasticsearchmonitor.MasterDetector - Found the following master information: MasterInformation(0,0,None)
[sbt-bg-threads-1] INFO com.gu.elasticsearchmonitor.Lambda$ - would have resolved with master node None, but forcing back to localhost as the lambda is running locally
[sbt-bg-threads-1] INFO com.gu.elasticsearchmonitor.ClusterHealth$ - Fetched the cluster health
[sbt-bg-threads-1] INFO com.gu.elasticsearchmonitor.NodeStats$ - Fetched the node stats
[sbt-bg-threads-1] INFO com.gu.elasticsearchmonitor.CloudwatchMetrics - About to send 54 metrics
[sbt-bg-threads-1] INFO com.gu.elasticsearchmonitor.CloudwatchMetrics - Sending a batch of 20 metrics to cloudwatch
[sbt-bg-threads-1] INFO com.gu.elasticsearchmonitor.CloudwatchMetrics - Sending a batch of 20 metrics to cloudwatch
[sbt-bg-threads-1] INFO com.gu.elasticsearchmonitor.CloudwatchMetrics - Sending a batch of 14 metrics to cloudwatch
[sbt-bg-threads-1] INFO com.gu.elasticsearchmonitor.Lambda$ - Successfully finished to send metrics to cloudwatch
()
[success] Total time: 6 s, completed 19 Jul 2023, 09:36:42

@akash1810 akash1810 merged commit fd923a9 into main Jul 19, 2023
1 check passed
@akash1810 akash1810 deleted the update/non_aws branch July 19, 2023 08:37
@jacobwinch
Copy link
Contributor

Following the test-data instructions resolves this

I'd forgotten about this - thanks for figuring it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants