remove redundant call to get productType

guardian · Oct 27, 2023 · 4dc6822 · 4dc6822
1 parent 3a6a79f
commit 4dc6822
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 12 deletions.
diff --git a/client/components/mma/delivery/address/DeliveryAddressForm.tsx b/client/components/mma/delivery/address/DeliveryAddressForm.tsx
@@ -437,12 +437,8 @@ export const DeliveryAddressUpdate = (props: WithProductType<ProductType>) => {
 		contactIdToArrayOfProductDetailAndProductType,
 	)
 		.flatMap(flattenEquivalent)
-		.some(({ productDetail }) => {
-			return (
-				GROUPED_PRODUCT_TYPES.subscriptions.mapGroupedToSpecific(
-					productDetail,
-				).productType === 'nationaldelivery'
-			);
+		.some(({ productType }) => {
+			return productType.productType === 'nationaldelivery';
 		});
 
 	if (hasNationalDelivery) {

diff --git a/client/components/mma/delivery/records/DeliveryAddressStep.tsx b/client/components/mma/delivery/records/DeliveryAddressStep.tsx
@@ -191,12 +191,8 @@ export const DeliveryAddressStep = (props: DeliveryAddressStepProps) => {
 			contactIdToArrayOfProductDetailAndProductType,
 		)
 			.flatMap(flattenEquivalent)
-			.some(({ productDetail }) => {
-				return (
-					GROUPED_PRODUCT_TYPES.subscriptions.mapGroupedToSpecific(
-						productDetail,
-					).productType === 'nationaldelivery'
-				);
+			.some(({ productType }) => {
+				return productType.productType === 'nationaldelivery';
 			});
 
 		if (hasNationalDelivery) {