Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook: Move to Component Story Format 3 #1232

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

andrewHEguardian
Copy link
Contributor

@andrewHEguardian andrewHEguardian commented Oct 25, 2023

What does this change?

Migrate existing stories to CSF 3, using npx storybook@next migrate csf-2-to-3 --glob="**/*.stories.tsx"

Use the new play function to interact with a component within CallCentrePrompt story!

How to test

How can we measure success?

Have we considered potential risks?

Images

Accessibility

Copy link
Contributor

@charleycampbell charleycampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great upgrade! Well done for implementing it - the interactive components are really cool and will be useful if testing anything on those pages 🎉

@andrewHEguardian andrewHEguardian merged commit 68c643f into main Nov 3, 2023
10 checks passed
@andrewHEguardian andrewHEguardian deleted the ahe/storybook-csf3 branch November 3, 2023 09:29
@prout-bot
Copy link
Collaborator

Overdue on PROD (merged by @andrewHEguardian 15 minutes and 5 seconds ago) What's gone wrong?

@prout-bot
Copy link
Collaborator

Seen on PROD (merged by @andrewHEguardian 79 hours, 9 minutes and 38 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants