Fix: Add support for quarterly billing period #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleycampbell
approved these changes
Nov 3, 2023
|
Seen on PROD (merged by @andrewHEguardian 9 minutes and 48 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds a small fix to support quarterly billing periods in update payment component. And to the test product builder.
How to test
Take out quarterly Guardian Weekly.
Update payment method.
Witness "quarterly" on screen.
How can we measure success?
Have we considered potential risks?
There are a lot of places in the code that assume certain products are either monthly or annual. Digisubs and Guardian Weekly can have quarterly billing periods. How do we ensure we don't make incorrect assumptions?
Images
Before
After
Accessibility