Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

National Delivery - add test case for multiple delivery addresses, where one is national #1240

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

andrewHEguardian
Copy link
Contributor

What does this change?

Follow up to #1234, as suggested by @charleycampbell. This PR adds a Cypress test where a user has multiple delivery products, one is national delivery and therefore they cannot update any of the addresses.

How to test

How can we measure success?

Have we considered potential risks?

Images

Accessibility

Copy link
Contributor

@charleycampbell charleycampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent follow up PR and an excellent edge case now tested! 🚀

@andrewHEguardian andrewHEguardian merged commit 5d04256 into main Nov 3, 2023
10 checks passed
@andrewHEguardian andrewHEguardian deleted the ahe/cypress-nat-del-address branch November 3, 2023 15:10
@prout-bot
Copy link
Collaborator

Overdue on PROD (merged by @andrewHEguardian 15 minutes and 8 seconds ago) What's gone wrong?

@prout-bot
Copy link
Collaborator

Seen on PROD (merged by @andrewHEguardian 73 hours, 29 minutes and 22 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants