Random todos

client/components/mma/shared/CardDisplay.tsx

@@ -1,7 +1,6 @@
 import type { SerializedStyles } from '@emotion/react';
 import { css } from '@emotion/react';
 import { palette } from '@guardian/source-foundations';
-import type { Inlineable } from './inlineable';
 
 interface CardExpiryDetails {
 	month: number;
@@ -14,7 +13,7 @@ export interface CardProps {
 	stripePublicKeyForUpdate?: string;
 }
 
-interface CardDisplayProps extends CardProps, Inlineable {
+interface CardDisplayProps extends CardProps {
 	cssOverrides?: SerializedStyles;
 	inErrorState?: boolean;
 }

client/components/mma/shared/DirectDebitDisplay.tsx

@@ -2,7 +2,6 @@ import { css } from '@emotion/react';
 import { from, palette } from '@guardian/source-foundations';
 import type { DirectDebitDetails } from '../../../../shared/productResponse';
 import { DirectDebitLogo } from './assets/DirectDebitLogo';
-import type { Inlineable } from './inlineable';
 
 const NUMBER_OF_ACCOUNT_NUMBER_DIGITS_TO_SHOW = 3;
 
@@ -54,11 +53,12 @@ export const sanitiseAccountNumber = (
 	);
 };
 
-interface DirectDebitDisplayProps extends DirectDebitDetails, Inlineable {
+interface DirectDebitDisplayProps extends DirectDebitDetails {
 	showAccountName?: true;
 	inErrorState?: boolean;
 	onlyAccountEnding?: true;
 	onlySortCode?: true;
+	inline?: true;
 }
 
 export const DirectDebitDisplay = (props: DirectDebitDisplayProps) => {

client/components/shared/SectionContent.tsx

@@ -82,9 +82,14 @@ const divCss = (hasNav: boolean | undefined) => css`
 	}
 `;
 
-export const SelectedTopicObjectContext = createContext<
-	Dispatch<SetStateAction<string | undefined>>
->(undefined!); // eslint-disable-line @typescript-eslint/no-non-null-assertion -- // TODO: refactor this var to remove need for disabling eslint rule
+const defaultDispatch = (_value: SetStateAction<string | undefined>) => {
+	return;
+};
+
+export const SelectedTopicObjectContext =
+	createContext<Dispatch<SetStateAction<string | undefined>>>(
+		defaultDispatch,
+	);
 
 export const SectionContent = (props: SectionContentProps) => {
 	const [selectedTopicId, setSelectedTopicId] = useState<string | undefined>(

shared/productTypes.ts

@@ -33,7 +33,7 @@ import { SoftOptInIDs } from './softOptInIDs';
 
 type ProductFriendlyName =
 	| 'Membership'
-	| 'recurring contribution' // TODO use payment frequency instead of 'recurring' e.g. monthly annual etc
+	| 'recurring contribution'
 	| 'newspaper subscription'
 	| 'newspaper voucher subscription'
 	| 'newspaper subscription card'