Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self cancellation of Digi subs is now controlled by MDAPI #1302

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

tjmw
Copy link
Member

@tjmw tjmw commented Jan 23, 2024

What does this change?

Here we update the fixture to reflect the data which is returned by MDAPI, changed in guardian/members-data-api#1041. This fixes a (mocked) Cypress test which is currently failing on main.

See also #1291.

How to test

How can we measure success?

Have we considered potential risks?

Images

Accessibility

Here we update the fixture to reflect the data which is returned by
MDAPI, changed in guardian/members-data-api#1041.
Copy link
Contributor

@andrewHEguardian andrewHEguardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good spot 👍

@tjmw tjmw merged commit 87153ab into main Jan 23, 2024
11 checks passed
@tjmw tjmw deleted the tw/fix-digisub-cancel-cypress-test branch January 23, 2024 13:00
@prout-bot
Copy link
Collaborator

Seen on PROD (merged by @tjmw 9 minutes and 47 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants