Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'+ extras' product name change #1336

Merged
merged 3 commits into from
May 20, 2024
Merged

'+ extras' product name change #1336

merged 3 commits into from
May 20, 2024

Conversation

rBangay
Copy link
Contributor

@rBangay rBangay commented May 17, 2024

What does this change?

Copy changes to refelect a switch from Monthly + extras and Annual + extras to All-access digital. Adjacent copy changes Recurring support to become subscription and visually grouping contributions and all access digital products into the 'subscriptions' sub section on the account overview

Images

Screenshot 2024-05-17 at 10 37 20 Screenshot 2024-05-17 at 10 37 58 Screenshot 2024-05-17 at 10 38 29

@rBangay rBangay requested a review from a team as a code owner May 17, 2024 09:38
@rBangay rBangay force-pushed the supporterplus-product-rename branch 2 times, most recently from 3e4fca2 to 45d2c0f Compare May 17, 2024 10:46
… + extras' to 'All-access digital'. Adjacent copy changes 'Recurring support' to become 'subscription' and visually grouping contributions and all access digital products into the 'subscriptions sub section on the account overview'
@rBangay rBangay force-pushed the supporterplus-product-rename branch from 45d2c0f to c9c40c6 Compare May 17, 2024 11:02
Copy link
Member

@tjmw tjmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I left a couple of nit-picky comments, but no blockers.

client/components/mma/accountoverview/AccountOverview.tsx Outdated Show resolved Hide resolved
cypress/tests/mocked/parallel-2/cancelSupporterPlus.cy.ts Outdated Show resolved Hide resolved
…more readable

lowercase the product title in the cancallation confirmation page title (also means that we can remove a property from the producttype object)
@rBangay rBangay force-pushed the supporterplus-product-rename branch from b6dd649 to c164820 Compare May 17, 2024 16:44
add comment to explain account overview visual grouping of contributions and supporter plus products
@rBangay rBangay merged commit a8d9b5d into main May 20, 2024
11 checks passed
@rBangay rBangay deleted the supporterplus-product-rename branch May 20, 2024 09:27
@prout-bot
Copy link
Collaborator

Seen on PROD (merged by @rBangay 11 minutes and 34 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants