-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'+ extras' product name change #1336
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rBangay
force-pushed
the
supporterplus-product-rename
branch
2 times, most recently
from
May 17, 2024 10:46
3e4fca2
to
45d2c0f
Compare
… + extras' to 'All-access digital'. Adjacent copy changes 'Recurring support' to become 'subscription' and visually grouping contributions and all access digital products into the 'subscriptions sub section on the account overview'
rBangay
force-pushed
the
supporterplus-product-rename
branch
from
May 17, 2024 11:02
45d2c0f
to
c9c40c6
Compare
tjmw
approved these changes
May 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I left a couple of nit-picky comments, but no blockers.
…more readable lowercase the product title in the cancallation confirmation page title (also means that we can remove a property from the producttype object)
rBangay
force-pushed
the
supporterplus-product-rename
branch
from
May 17, 2024 16:44
b6dd649
to
c164820
Compare
johnduffell
reviewed
May 20, 2024
johnduffell
reviewed
May 20, 2024
add comment to explain account overview visual grouping of contributions and supporter plus products
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Copy changes to refelect a switch from
Monthly + extras
andAnnual + extras
toAll-access digital
. Adjacent copy changesRecurring support
to becomesubscription
and visually grouping contributions and all access digital products into the 'subscriptions' sub section on the account overviewImages