Update source dependencies #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rBangay
force-pushed
the
update-source-dependencies
branch
2 times, most recently
from
6327921
to
8b73263
Compare
rBangay
force-pushed
the
update-source-dependencies
branch
from
8b73263
to
7eef674
Compare
rBangay
commented
May 23, 2024
| @@ -385,7 +381,7 @@ export const ProductCard = ({ | |||
| </h4> | |||
| <div> | |||
| <dl css={keyValueCss}> | |||
| <dt>{atob('TFBQRlJFRTZHTFRY')}</dt> | |||
| <dt>{window.atob('TFBQRlJFRTZHTFRY')}</dt> | |||
There was a problem hiding this comment.
the linter seems to get confused between the browser and node versions of this function, the node one throwing a deprecation warning. This should force the hand of the linter to let it know that we are only concerned with the browser implimentation here.
reference: microsoft/TypeScript#45566
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Update to:
Including deprecated changes to theming.