Guardian source update #1339
Merged
Guardian source update #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omponents-development-kitchen dependencies
…y used minor version
rBangay
force-pushed
the
guardian-source-update
branch
from
1f3c856
to
af1a67c
Compare
sndrs
reviewed
May 28, 2024
Yea looks good to me too |
sndrs
approved these changes
May 28, 2024
| `; | ||
|
|
||
| const linkCss = css` | ||
| display: flex; | ||
| align-items: center; | ||
| ${textSans.medium()}; | ||
| color: ${palette.brand[500]}; | ||
| ${textSans17}: color: ${palette.brand[500]}; |
There was a problem hiding this comment.
Should be a semicolon rather than a colon here.
Suggested change
| ${textSans17}: color: ${palette.brand[500]}; | |
| ${textSans17}; | |
| color: ${palette.brand[500]}; |
There was a problem hiding this comment.
AAAH, good spot, I'll fix this with a subsequent small pr. It only seems to affect the link colour and nothing more serious.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Updates the following dependancies:
Replaces deprecated usages of source resources like theme and typography .
Minor version updates for both node and typescript