-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guardian source update #1339
Guardian source update #1339
Conversation
…omponents-development-kitchen dependencies
…y used minor version
1f3c856
to
af1a67c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - @jamesmockett @oliverabrahams you too?
Yea looks good to me too |
`; | ||
|
||
const linkCss = css` | ||
display: flex; | ||
align-items: center; | ||
${textSans.medium()}; | ||
color: ${palette.brand[500]}; | ||
${textSans17}: color: ${palette.brand[500]}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be a semicolon rather than a colon here.
${textSans17}: color: ${palette.brand[500]}; | |
${textSans17}; | |
color: ${palette.brand[500]}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AAAH, good spot, I'll fix this with a subsequent small pr. It only seems to affect the link colour and nothing more serious.
What does this change?
Updates the following dependancies:
Replaces deprecated usages of source resources like theme and typography .
Minor version updates for both node and typescript