csp header css update #1343
Merged
csp header css update #1343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tyle attribute css in the csp header. We don't want to be doing this but is a nesacery step to implementing a csp header until we can look more closely at verifying sources either with a hash or nonce
johnduffell
reviewed
Jun 5, 2024
johnduffell
reviewed
Jun 5, 2024
johnduffell
approved these changes
Jun 5, 2024
tjmw
approved these changes
Jun 5, 2024
remove unnecessary line Co-authored-by: John Duffell <john.duffell@guardian.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Change invalid
default-styleto the correctstyle-srchttps://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy/style-srcThis will allow inline styles for
<style>and<link>tags as well as inlinestyleattribute.This is not a welcome attribute but a necessary one in order to implement a csp header in manage. Hopefully at a later date we can look into using a hash or nonce to validate specific inline sources.