Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supporter plus price rise #1347

Merged
merged 4 commits into from
Jul 1, 2024
Merged

supporter plus price rise #1347

merged 4 commits into from
Jul 1, 2024

Conversation

rBangay
Copy link
Contributor

@rBangay rBangay commented Jun 26, 2024

What does this change?

Update the supporter plus min amount threshold prices to align with an inbound checkout price rise

Trello card

https://trello.com/c/yp41n8NB/353-supporter-plus-price-rise-upsell

Do not merge until instructed to by our P&P team overlords 👑

@rBangay rBangay requested a review from a team as a code owner June 26, 2024 15:23
@johnduffell
Copy link
Member

where it the source data for this? is there a card or spreadsheet for it?

@rBangay
Copy link
Contributor Author

rBangay commented Jun 28, 2024

where it the source data for this? is there a card or spreadsheet for it?

Yep, theres a link to the spreadsheet in the trello card:

https://trello.com/c/yp41n8NB/353-supporter-plus-price-rise-upsell

I'll add the card to the pr descriotion as well

}
if (amount <= 8) {
return [10, 12, 15];
}
if (amount <= 9) {
if (amount === 9) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why has this line changed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someone could be on 8.50 if they've typed in an other amount. Then they'd see the higher suggested amounts, such an edge case that it's probably not worth thinking about

Copy link
Member

@rupertbates rupertbates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question about why <= has become === in a number of places.

@rBangay
Copy link
Contributor Author

rBangay commented Jul 1, 2024

One question about why <= has become === in a number of places.

Becuase it marries with the source data in the spreadsheet ... (functionaly it makes no difference with the lower conditions above in the code catching the < cases). it's more explicit now

Copy link

@paul-daniel-dempsey paul-daniel-dempsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - amount changes look exactly as in price-rise spreadsheet

@rBangay rBangay merged commit 7c900b9 into main Jul 1, 2024
13 checks passed
@rBangay rBangay deleted the sp-price-rise branch July 1, 2024 13:22
@prout-bot
Copy link
Collaborator

Seen on PROD (merged by @rBangay 9 minutes and 33 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants