-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
supporter plus price rise #1347
Conversation
…n inbound checkout price rise
where it the source data for this? is there a card or spreadsheet for it? |
Yep, theres a link to the spreadsheet in the trello card: https://trello.com/c/yp41n8NB/353-supporter-plus-price-rise-upsell I'll add the card to the pr descriotion as well |
} | ||
if (amount <= 8) { | ||
return [10, 12, 15]; | ||
} | ||
if (amount <= 9) { | ||
if (amount === 9) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why has this line changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Someone could be on 8.50 if they've typed in an other amount. Then they'd see the higher suggested amounts, such an edge case that it's probably not worth thinking about
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question about why <= has become === in a number of places.
Becuase it marries with the source data in the spreadsheet ... (functionaly it makes no difference with the lower conditions above in the code catching the < cases). it's more explicit now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - amount changes look exactly as in price-rise spreadsheet
What does this change?
Update the supporter plus min amount threshold prices to align with an inbound checkout price rise
Trello card
https://trello.com/c/yp41n8NB/353-supporter-plus-price-rise-upsell
Do not merge until instructed to by our P&P team overlords 👑