remove doNotSetUsername param as we no longer set username for test users #1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnduffell
commented
Jul 3, 2024
| } as IDAPITestUserOptions, | ||
| }) | ||
| .then((res) => { | ||
| return cy.wrap({ | ||
| emailAddress: finalEmail, | ||
| emailAddress: res.body.emailAddress as string, |
There was a problem hiding this comment.
this is similar to this PR guardian/gateway#2791
we need to get the email address from the response, as the email address will be augmented with the test user token
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows on when this one https://github.com/guardian/identity/pull/2528 is merged - the cypress tests will fail until then.
Identity no longer will support the doNotSetUsername param because we will never set the username for test users.
(It undoes some of the changes in #1311 which were added when it became no longer possible to set the username more than once)
That flag is removed in the identity PR https://github.com/guardian/identity/pull/2528 as part of the changes to move the test user token from the username/firstname to the email address