Fix flaky cypress tests to use data-cy
#1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphaelkabo
force-pushed
the
rk/fix-ete-test
branch
from
21c69fe
to
a8e91f1
Compare
raphaelkabo
force-pushed
the
rk/fix-ete-test
branch
from
a8e91f1
to
296d767
Compare
coldlink
approved these changes
Jul 17, 2024
|
Seen on PROD (merged by @raphaelkabo 9 minutes and 30 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current situation/background
We used a string label to target a checkbox in our Cypress tests - this has broken because the label changed in the backend.
What does this PR change?
We now set the
data-cyHTML attribute to the id of the newsletter/consent for that checkbox. The ID never changes even if the label does, so this will make our tests much more reliable.Testing
Tested by the tests passing!