Top tier copy changes #1366
Merged
Top tier copy changes #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rBangay
force-pushed
the
top-tier-copy-changes
branch
from
9cefd49
to
70c8f07
Compare
| @@ -532,15 +532,15 @@ export function baseTierThree(): ProductDetail { | |||
| country: 'United Kingdom', | |||
| }, | |||
| safeToUpdatePaymentMethod: true, | |||
| start: '2024-06-28', | |||
| end: '2025-06-13', | |||
| start: '2021-12-24', | |||
There was a problem hiding this comment.
Out of curiosity, why are these set to dates in the past?
There was a problem hiding this comment.
I moved them into the past to line up with the mocked data for the potential holiday stop api response. I could have setup some new holiday stop dates specifically for top tier, or updated the dates for all products everywhere, but I thought this was the simplest thing to do.
tjmw
approved these changes
Jul 31, 2024
| @@ -183,19 +193,16 @@ const actuallyCancelled = ( | |||
| export const isCancelled = (subscription: Subscription) => | |||
| Object.keys(subscription).length === 0 || subscription.cancelledAt; | |||
|
|
|||
| export const getCancellationSummary = | |||
| (productType: ProductType, cancelledProductDetail: ProductDetail) => | |||
| (productDetail: ProductDetail) => | |||
There was a problem hiding this comment.
Nice work getting rid of the extra layer of function application here 👍 It seems like it's definitely not needed - all of the call sites I can see immediately call the returned function, passing the same value as was passed in the initial call.
only call 'getMainPlan' function on the cancellation summary page if the required properties on the subscription object exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Copy changed for the top tier (digital + print) product, which was modelled after the Guardian weekly product.
Minor refactor of the cancellation confirmation page to remove unnecessary product detail providing closure.