Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 3 x benefit CTAs to Account Overview for readers with a digital + print sub #1374

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Add 3 x benefit CTAs to Account Overview for readers with a digital + print sub #1374

wants to merge 25 commits into from

Commits on Oct 7, 2024

  1. WIP add news archive, news and feast app cts's to the account overvie… 

    …w for people with digital + print subscriptions

Renames the existing Feast cta component to DownloadFeastAppCtaWithIcon
and introduces a new component DownloadFeastAppCtaWithImage for the
account overview screen.
    @tjmw
    Richard Bangay authored and tjmw committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    184bfbb View commit details
    Browse the repository at this point in the history

  2. Add story for NewspaperArchiveCta

    @tjmw
    tjmw committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    3a59c91 View commit details
    Browse the repository at this point in the history

  3. Increase image max-width at >= tablet

    @tjmw
    tjmw committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    1cc5d8d View commit details
    Browse the repository at this point in the history

  4. Set spacing between flex items

    @tjmw
    tjmw committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    d4d03ac View commit details
    Browse the repository at this point in the history

  5. Update copy (from Figma)

    @tjmw
    tjmw committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    2d3522a View commit details
    Browse the repository at this point in the history

  6. Add stories for these two cta components

    @tjmw
    tjmw committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    8ec532d View commit details
    Browse the repository at this point in the history

  7. Apply same layout tweaks already made to newspaper archive CTA

    @tjmw
    tjmw committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    076df30 View commit details
    Browse the repository at this point in the history

  8. Add gradient background to hero image on mobile 

    Only the newsletter archive component for now, will apply to the others
in a separate commit.
    @tjmw
    tjmw committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    18d9530 View commit details
    Browse the repository at this point in the history

  9. Same changes to Feast CTA

    @tjmw
    tjmw committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    2fe282b View commit details
    Browse the repository at this point in the history

  10. Fix horizontal alignment of hero image 

    I'd broken this when adding the linear gradient on mobile (but hadn't
noticed as this only affects >= tablet).
    @tjmw
    tjmw committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    daeb846 View commit details
    Browse the repository at this point in the history

  11. Add linear gradient to news app CTA

    @tjmw
    tjmw committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    e7a85c3 View commit details
    Browse the repository at this point in the history

  12. Use flex-grow instead of width 100% 

    The width 100% on the container was causing this flex item to be too
greedy.
    @tjmw
    tjmw committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    14377ea View commit details
    Browse the repository at this point in the history

  13. Oops accidentally reverted the copy

    @tjmw
    tjmw committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    f542337 View commit details
    Browse the repository at this point in the history

  14. Prevent images from overflowing the container on mobile

    @tjmw
    tjmw committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    6a763b8 View commit details
    Browse the repository at this point in the history

  15. Update bg colours and text sizing

    @tjmw
    tjmw committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    357259f View commit details
    Browse the repository at this point in the history

  16. Update copy

    @tjmw
    tjmw committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    a36ff74 View commit details
    Browse the repository at this point in the history

  17. Update archive URL

    @tjmw
    tjmw committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    b5fbf40 View commit details
    Browse the repository at this point in the history

  18. Remove inconsistent padding at >= tablet on news app copy container

    @tjmw
    tjmw committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    fbe3e03 View commit details
    Browse the repository at this point in the history

  19. Reduce size of Newspaper Archive CTA

    @tjmw
    tjmw committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    a052f35 View commit details
    Browse the repository at this point in the history

  20. Open the Newspaper Archive in a new tab 

    We discussed the best approach as a team, and based on the advice [here]
we think there's a good argument that this counts as a launching-off
point.

[here]: https://www.nngroup.com/articles/new-browser-windows-and-tabs/
    @tjmw
    tjmw committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    2972a15 View commit details
    Browse the repository at this point in the history

  21. New images from Helene

    @tjmw
    tjmw committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    d7e384e View commit details
    Browse the repository at this point in the history

  22. Use different image on mobile 

    Also tweak the css to ensure the image is always anchored to the bottom
of the container.
    @tjmw
    tjmw committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    1288242 View commit details
    Browse the repository at this point in the history

  23. Ensure these images are anchored to the bottom of the container 

    Only an issue if the text ever grows.
    @tjmw
    tjmw committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    1e23802 View commit details
    Browse the repository at this point in the history

  24. New newspaper archive mobile image from Noemi

    @tjmw
    tjmw committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    ba5b883 View commit details
    Browse the repository at this point in the history

  25. Fix story 

    It referred to the old component name which no longer exists.
    @tjmw
    tjmw committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    55e47ef View commit details
    Browse the repository at this point in the history