Use discount api response for cancellation offer payment date #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ancellation offer journey
rBangay
force-pushed
the
supporter-plus-cancellation-offer-pricing
branch
from
581ef98
to
74d0a91
Compare
rBangay
changed the title
tjmw
approved these changes
Sep 6, 2024
Comment on lines
178
to
181
| const strikethroughPrice = routerState.nonDiscountedPayments.reduce( | ||
| (prev, current) => | ||
| prev && prev.amount > current.amount ? prev : current, | ||
| ).amount; |
There was a problem hiding this comment.
Not that I'm not a fan of reduce (I am, and think I probably overuse it) but what about this as an alternative? Maybe it's slightly clearer what the intention is?
Suggested change
| const strikethroughPrice = routerState.nonDiscountedPayments.reduce( | |
| (prev, current) => | |
| prev && prev.amount > current.amount ? prev : current, | |
| ).amount; | |
| const strikethroughPrice = Math.max(...routerState.nonDiscountedPayments.map(p => p.amount)); |
Or splitting it into two:
const allAmounts = routerState.nonDiscountedPayments.map(p => p.amount);
const strikeThroughPrice = Math.max(...allAmounts);
Comment on lines
189
to
192
| const nextNonDiscountedPrice = routerState.nonDiscountedPayments.reduce( | ||
| (prev, current) => | ||
| prev && prev.amount > current.amount ? prev : current, | ||
| ).amount; |
There was a problem hiding this comment.
Would it be worth extracting this to a method, since it's the same logic repeated in SupporterPlusOffer.tsx?
…various components into a utility function that can be shared
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Use the discount api response to return the next payment price (after the cancellation offer period ends). This should handle the case where the returning payment price will be different from the price paid before the offer was taken up, a price rise for example 👍