-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconfigure notification sender worker alarms #1181
Conversation
912133b
to
895f9c3
Compare
c40ce68
to
5551094
Compare
exports[`The MobileAppsRendering stack matches the snapshot 1`] = ` | ||
exports[`The Sender Worker stack matches the snapshot 1`] = ` | ||
Object { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong test name! Probably a copy/paste job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch
5551094
to
bb9f716
Compare
Update snap Disable alarm on CODE increase alarm period Once a day for editions as they only send one notification a day. Once every 30 minutes for others as we often times go more than 30 minutes without sending a notification. Reinstate on CODE remove line test with short period
bb9f716
to
f4b4e1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Why
We have many alarms related to this stack in a permanent state of alarm. This is because they're configured to alarm if no invocations in 6 minutes. However....
What does this change?
This change reconfigures our notification sender worker alarms.
These changes should mean our alarms are more useful and enable us to act on them in case of something going wrong by subscribing them to our alerts channel.
Testing
To test the alerts to our channel, I changed the period to 1 minute and deployed to CODE to ensure we would get alerts.