Reconfigure notification sender worker alarms #1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkgnm
force-pushed
the
alarm-on-prod-only
branch
2 times, most recently
from
912133b
to
895f9c3
Compare
tkgnm
changed the title
tkgnm
force-pushed
the
alarm-on-prod-only
branch
from
c40ce68
to
5551094
Compare
tkgnm
commented
Nov 10, 2023
Comment on lines
-3
to
4
| exports[`The MobileAppsRendering stack matches the snapshot 1`] = ` | ||
| exports[`The Sender Worker stack matches the snapshot 1`] = ` | ||
| Object { |
There was a problem hiding this comment.
Wrong test name! Probably a copy/paste job.
tkgnm
force-pushed
the
alarm-on-prod-only
branch
from
5551094
to
bb9f716
Compare
Update snap Disable alarm on CODE increase alarm period Once a day for editions as they only send one notification a day. Once every 30 minutes for others as we often times go more than 30 minutes without sending a notification. Reinstate on CODE remove line test with short period
tkgnm
force-pushed
the
alarm-on-prod-only
branch
from
bb9f716
to
f4b4e1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We have many alarms related to this stack in a permanent state of alarm. This is because they're configured to alarm if no invocations in 6 minutes. However....
What does this change?
This change reconfigures our notification sender worker alarms.
These changes should mean our alarms are more useful and enable us to act on them in case of something going wrong by subscribing them to our alerts channel.
Testing
To test the alerts to our channel, I changed the period to 1 minute and deployed to CODE to ensure we would get alerts.