-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Play 3.0 upgrade #1214
Play 3.0 upgrade #1214
Conversation
Tests on Common and API-models haven't been run, and should be before this is merged |
f0a9b4c
to
09c7b2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @davidfurey for upgrading n10n to Play3.0.
I tried sending a test notification on CODE with this branch. However, the harvester lambda threw this exception and I'm not sure if it is relevant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested the latest snapshot and a test notification has been sent successfully.
It appears that we have to exclude com.typesafe.play
bundles explicitly when the project depends on "ai.x" %% "play-json-extensions"
(because it brings in the old play-json transitively). I am wondering whether we should also add the exclusion rule to the subproject notification
, registration
and report
? Or have I missed anything (as the notification and registration API can work properly on CODE)?
You are correct, the exclusion should also be applied to notification, registration and report. I've pushed a commit with that |
b45fb61
to
e39c9ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the changes by sending a test notification and my app on Android simulator was able to receive it.
Thank you @davidfurey for upgrading the n10n service to Play 3.0
@waisingyiu do you think we have done sufficient testing to merge this? |
Yes, I think the testing should be sufficient. I ran the following tests
I am happy to merge it and keep an eye on it tomorrow morning if it helps? |
That would be great, thanks! |
What does this change?
Minimal changes to upgrade to Play 3.0
How to test
How can we measure success?
Have we considered potential risks?
Images
Accessibility