LIVE-6447 Create a connection for the processing of each SQS message #1217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waisingyiu
force-pushed
the
LIVE-6447-create-a-connection-for-each-message
branch
from
3a3d50a
to
b5eb60e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I paired with @aracho1 on this piece of work.
What does this change?
After merging PR #1216 , we saw IO exceptions when the android sender lambda sent notifications to a relatively larger group of device (more than several hundreds).
We used the same
HttpClientinstance for the processing of all SQS messages within an invocation of a lambda, and it appears that theHttpClientsent the requests over the same connection via HTTP/2. In larger notifications, it hit the limit on the maximum of concurrent stream over a connection.This PR attempts to fix the problem by creating a
HttpClientinstance for the processing of each SQS message. Within each SQS message, there is a setting on concurrency level which specifies how many device token to send concurrently. This approach helps us to control the maximum number of concurrent stream we open when sending requests to Firebase API.How to test
We tested locally and confirmed that we created as many
HttpClientinstances as the messages we are processing.We also deployed to
CODE, tested a notification and we were able to receive it on our Android emulator.