Merged
Conversation
dblatcher
approved these changes
Jul 25, 2025
|
Seen on PROD (merged by @waisingyiu 3 minutes and 17 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
This pull request is part of the work to address the FSBP high severity issue about the bucket
pan-domain-auth-settingsnot blocking public access. We observed that some S3 objects (specifically, the public key files) in this bucket were accessed via direct HTTP URL without any credential usingpan-domain-nodelibrary.We changed the
pan-domain-nodelibrary (guardian/pan-domain-node#47) to get the public key files with AWS SDK that requires AWS credentials in the execution environment. This change was published to the NPM repository as version 1.1.0.This pull request bumps the
pan-domain-nodedependency to version 1.2.0 (the latest version that includes the change described above) so that it reads the public key files by AWS SDK rather than unauthenticated direct HTTP request.How to test
We can see a "pinboard pre-selection" page when we hit the endpoint "https://pinboard.local.dev-gutools.co.uk/" while running it locally.
Deployed it to CODE and open the Composer CODE.
How can we measure success?
Make progress towards enabling "block all public access" on the S3 bucket "pan-domain-auth-settings".
Have we considered potential risks?
Should be minimal because the same bucket is shared between CODE and PROD. If the application can access the public key file on CODE, it should be able to do it on PROD.