Skip to content

Bumps GuCDK to 62.1.1#374

Merged
LAKSHMIRPILLAI merged 3 commits intomainfrom
lp-upgrade-aws-js-v3
Dec 4, 2025
Merged

Bumps GuCDK to 62.1.1#374
LAKSHMIRPILLAI merged 3 commits intomainfrom
lp-upgrade-aws-js-v3

Conversation

@LAKSHMIRPILLAI
Copy link
Contributor

@LAKSHMIRPILLAI LAKSHMIRPILLAI commented Dec 2, 2025

What does this change?

This PR bumps various CDK dependencies and removes the project's use of AWS SDK V2, covered in https://github.com/guardian/workflow/issues/1273.

How to test

  1. Deploy this branch to CODE
  2. Open Composer CODE
  3. Open Pinboard and check if everything is working as usual and we are getting 200 response

How can we measure success?

No usage of AWS SDK V2 and latest Guardian CDK changes.

Note: At one step , running yarn dedupe --check caused some failures saying -' 74 packages can be deduped using the highest strategy. Resolved this by running 'yarn dedupe --strategy highest' which updated the yarn.lock file

@LAKSHMIRPILLAI LAKSHMIRPILLAI marked this pull request as ready for review December 3, 2025 10:35
@LAKSHMIRPILLAI LAKSHMIRPILLAI requested review from a team and twrichards as code owners December 3, 2025 10:35
Copy link
Collaborator

@twrichards twrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @LAKSHMIRPILLAI - great work 🙌

I noticed you deployed to CODE so I've just tested
Image

@liamness
Copy link
Contributor

liamness commented Dec 3, 2025

Will this require the two-stage PR approach to removing the Wazuh security group? See the release notes from @guardian/cdk:

https://github.com/guardian/cdk/releases/tag/v61.5.0

Having said that, when I tried releasing guardian/editorial-collaboration#24 to CODE without first doing this tweak, the riffraff deploy failed. So if you have already tested this on code, maybe there is some reason why it isn't necessary here?

@twrichards
Copy link
Collaborator

twrichards commented Dec 3, 2025

Will this require the two-stage PR approach to removing the Wazuh security group? See the release notes from @guardian/cdk:

guardian/cdk@v61.5.0 (release)

Having said that, when I tried releasing guardian/editorial-collaboration#24 to CODE without first doing this tweak, the riffraff deploy failed. So if you have already tested this on code, maybe there is some reason why it isn't necessary here?

good point/question!

just a guess, but I imagine that in your case the security group couldn't be deleted because there were active EC2 instances using it, but for Pinboard we only use EC2 very occasionally to spin up a box to use as a jump host to the [private] DB (as pinboard is otherwise serverless), the ASG is normally zero. so I think the PROD CD should be fine here 🤞

@LAKSHMIRPILLAI LAKSHMIRPILLAI merged commit 8eb26b3 into main Dec 4, 2025
4 checks passed
@LAKSHMIRPILLAI LAKSHMIRPILLAI deleted the lp-upgrade-aws-js-v3 branch December 4, 2025 11:44
@gu-prout
Copy link

gu-prout bot commented Dec 4, 2025

Seen on PROD (merged by @LAKSHMIRPILLAI 4 minutes and 21 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants