Conversation
twrichards
left a comment
There was a problem hiding this comment.
thanks @LAKSHMIRPILLAI - great work 🙌
|
Will this require the two-stage PR approach to removing the Wazuh security group? See the release notes from https://github.com/guardian/cdk/releases/tag/v61.5.0 Having said that, when I tried releasing guardian/editorial-collaboration#24 to CODE without first doing this tweak, the riffraff deploy failed. So if you have already tested this on code, maybe there is some reason why it isn't necessary here? |
good point/question! just a guess, but I imagine that in your case the security group couldn't be deleted because there were active EC2 instances using it, but for Pinboard we only use EC2 very occasionally to spin up a box to use as a jump host to the [private] DB (as pinboard is otherwise serverless), the ASG is normally zero. so I think the PROD CD should be fine here 🤞 |
|
Seen on PROD (merged by @LAKSHMIRPILLAI 4 minutes and 21 seconds ago) Please check your changes! |

What does this change?
This PR bumps various CDK dependencies and removes the project's use of AWS SDK V2, covered in https://github.com/guardian/workflow/issues/1273.
How to test
How can we measure success?
No usage of AWS SDK V2 and latest Guardian CDK changes.
Note: At one step , running yarn dedupe --check caused some failures saying -' 74 packages can be deduped using the highest strategy. Resolved this by running 'yarn dedupe --strategy highest' which updated the yarn.lock file