Draft
Conversation
davidfurey
reviewed
Jan 10, 2025
| * Also ensures the user is in the correct Google Groups, as defined by the given GroupCheckConfig | ||
| */ | ||
| def processOauth2Callback(requiredGoogleGroups: Set[String], groupChecker: GoogleGroupChecker) | ||
| def processOauth2Callback(groupCheckConfig: GroupCheckConfig, groupChecker: GoogleGroupChecker) |
Member
There was a problem hiding this comment.
Instead of changing the signature of this method, I would be inclined to add a new method with this new signature, and keep the old method but marked as deprecated. Should hopefully make upgrades easier for other teams.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
requiredGroupsparameter is used to ensure a user is in all groups in the set.It would also be useful to be able to check if a user is in at least one of the groups in a set.
This PR refactors the group checking logic in
processOauth2Callback, to optionally support both:requiredGroups, with the existing behaviourallowedGroups, of which a user must be in a least one group