simplify ZuoraRenewOrderResponse type

guardian · Oct 22, 2024 · ce42bd9 · ce42bd9
1 parent 7a61ee9
commit ce42bd9
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 10 deletions.
diff --git a/lambda/src/main/scala/pricemigrationengine/model/ZuoraRenewOrderPayload.scala b/lambda/src/main/scala/pricemigrationengine/model/ZuoraRenewOrderPayload.scala
@@ -84,14 +84,13 @@ object ZuoraRenewOrderPayload {
   }
 }
 
-case class ZuoraRenewOrderResponseReason(code: Long, message: String)
-object ZuoraRenewOrderResponseReason {
-  implicit val rwZuoraRenewOrderResponseReason: ReadWriter[ZuoraRenewOrderResponseReason] = macroRW
-}
+//case class ZuoraRenewOrderResponseReason(code: Long, message: String)
+//object ZuoraRenewOrderResponseReason {
+//  implicit val rwZuoraRenewOrderResponseReason: ReadWriter[ZuoraRenewOrderResponseReason] = macroRW
+//}
 
 case class ZuoraRenewOrderResponse(
-    success: Boolean,
-    reasons: Option[List[ZuoraRenewOrderResponseReason]],
+    success: Boolean
 )
 object ZuoraRenewOrderResponse {
   implicit val rwZuoraRenewOrderResponse: ReadWriter[ZuoraRenewOrderResponse] = macroRW

diff --git a/lambda/src/main/scala/pricemigrationengine/services/ZuoraLive.scala b/lambda/src/main/scala/pricemigrationengine/services/ZuoraLive.scala
@@ -220,16 +220,16 @@ object ZuoraLive {
             failure = e =>
               ZIO.fail(
                 ZuoraRenewalFailure(
-                  s"Subscription number: $subscriptionNumber, payload: ${payload}, reason: ${e.reason}"
+                  s"[06f5bd6f] subscription number: $subscriptionNumber, payload: ${payload}, reason: ${e.reason}"
                 )
               ),
-            success = answer =>
-              if (answer.success) {
+            success = response =>
+              if (response.success) {
                 ZIO.succeed(())
               } else {
                 ZIO.fail(
                   ZuoraRenewalFailure(
-                    s"Subscription number: $subscriptionNumber, payload: ${payload}, with answer ${answer}"
+                    s"[bc532694] subscription number: $subscriptionNumber, payload: ${payload}, with answer ${response}"
                   )
                 )
               }