Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add id to ZuoraSubscription #1089

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Add id to ZuoraSubscription #1089

merged 1 commit into from
Oct 25, 2024

Conversation

shtukas
Copy link
Contributor

@shtukas shtukas commented Oct 25, 2024

Add the id attribute to a ZuoraSubscription which, interestingly, didn't have it. (This is preliminary work for the Zuora Orders migration for amendments).

@shtukas shtukas requested a review from a team as a code owner October 25, 2024 14:53
@shtukas
Copy link
Contributor Author

shtukas commented Oct 25, 2024

Motivation:

The new subscription Id (post amendment), is written in the DynamoTable here:

(more exactly is used to make an instance of SuccessfulAmendmentResult which is then written to the table.)

We get it in the answer of the amendment call itself:

newSubscriptionId <- Zuora.updateSubscription(subscriptionBeforeUpdate, update)

But since I will be using the new API, I would like to be able to query Zuora post calling the new API and read it from the subscription itself.

@shtukas shtukas merged commit 895316f into main Oct 25, 2024
3 checks passed
@shtukas shtukas deleted the ph-20241025-1530-subscription-id branch October 25, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants