Introduce MigrationType #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelvin-chappell
approved these changes
Jul 13, 2023
Comment on lines
+162
to
+166
| forceEstimated = MigrationType(cohortSpec) match { | ||
| case Membership2023Monthlies => true | ||
| case Membership2023Annuals => true | ||
| case _ => false | ||
| } |
There was a problem hiding this comment.
Not sure if this is an improvement or not:
Suggested change
| forceEstimated = MigrationType(cohortSpec) match { | |
| case Membership2023Monthlies => true | |
| case Membership2023Annuals => true | |
| case _ => false | |
| } | |
| forceEstimated = MigrationType(cohortSpec) == Membership2023Monthlies || MigrationType(cohortSpec) == Membership2023Annuals |
Comment on lines
+84
to
+88
| val forceEstimated = MigrationType(cohortSpec) match { | ||
| case Membership2023Monthlies => true | ||
| case Membership2023Annuals => true | ||
| case _ => false | ||
| } |
There was a problem hiding this comment.
This is same as above. Could possibly be extracted
|
@kelvin-chappell
I am going to leave it as it is, because I am just about to add a new migration type, and will refactor (make those simplifications) once the new one is in :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we introduced the 2023 membership price migrations, we introduced the concept of parametrisation of basic functions with
CohortSpecs. Back then we got away withif (cohort detections) then ... else (else if ...)the existing code, but with more of such customised migrations coming, it was time for a refactoring.For this we introduce
sealed trait MigrationType, leading to a much cleaner and more readable code.MigrationTypedoes not identity a migration (Sometime several migrations map to a unique migration type, for instance both Membership 2023 Batch 1 and Batch 2 both map to typeMembership2023Monthlies, whereas Membership 2023 Batch 3 identifies withMembership2023Annuals. It simply helps identify common code used by possibly more than one migration.All pre 2023 migrations map to type
Legacy.