Deal with buckets being collected from multiple regions #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two issues here - buckets are a global service so we need to filter and also if we are crawling us-east-1 and we look at buckets from another region all hell breaks loose. See aws/aws-sdk-java#1338
philmcmahon
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two issues here
us-east-1and we look at a bucket from another region all hell breaks loose: see S3 Get Bucket Location does not consistently fail depending on client region aws/aws-sdk-java#1338Tested in CODE (with Prism configured to crawl
us-east-1in addition toeu-west-1).